feat(core): don't schedule search without widgets #5056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the behavior of the
start()
method to only schedule a search when there are widgets statically added beforehand. Scheduling a search without widget is a unnecessary operation because there are no listeners at this point to use the search results.This behavior is required for React InstantSearch Hooks with React 18 to support new concurrent features. We don't have any certainty about the order of execution of our effects anymore in
<InstantSearch>
anduseConnector()
, so we would sometimes end up triggering a single network request, or sometimes two (fromstart()
, and then fromaddWidgets()
).This eliminates the problem altogether because our framework-based flavors never rely on the search coming from
start()
, but on the search coming fromaddWidgets()
.Impact
Related
useSyncExternalStore()
react-instantsearch#3489