fix(indexUtils): avoid throw an error on cleanUp multi indices (#1265)

* fix(indexUtils): avoid to throw an error when we cleanUp an index that not exist * refactor(indexUtils): use multiple functions for cleanUp
algolia · May 24, 2018 · 12f5ace · 12f5ace
1 parent 06134a7
commit 12f5ace
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 23 deletions.
diff --git a/packages/react-instantsearch/src/core/indexUtils.js b/packages/react-instantsearch/src/core/indexUtils.js
@@ -187,30 +187,64 @@ export function getCurrentRefinementValue(
 }
 
 export function cleanUpValue(searchState, context, id) {
-  const index = getIndex(context);
+  const indexName = getIndex(context);
   const { namespace, attributeName } = getNamespaceAndAttributeName(id);
+
   if (hasMultipleIndex(context) && Boolean(searchState.indices)) {
-    return namespace
-      ? {
-          ...searchState,
-          indices: {
-            ...searchState.indices,
-            [index]: {
-              ...searchState.indices[index],
-              [namespace]: omit(
-                searchState.indices[index][namespace],
-                `${attributeName}`
-              ),
-            },
-          },
-        }
-      : omit(searchState, `indices.${index}.${id}`);
-  } else {
-    return namespace
-      ? {
-          ...searchState,
-          [namespace]: omit(searchState[namespace], `${attributeName}`),
-        }
-      : omit(searchState, `${id}`);
+    return cleanUpValueWithMutliIndex({
+      attribute: attributeName,
+      searchState,
+      indexName,
+      id,
+      namespace,
+    });
+  }
+
+  return cleanUpValueWithSingleIndex({
+    attribute: attributeName,
+    searchState,
+    id,
+    namespace,
+  });
+}
+
+function cleanUpValueWithSingleIndex({
+  searchState,
+  id,
+  namespace,
+  attribute,
+}) {
+  if (namespace) {
+    return {
+      ...searchState,
+      [namespace]: omit(searchState[namespace], attribute),
+    };
   }
+
+  return omit(searchState, id);
+}
+
+function cleanUpValueWithMutliIndex({
+  searchState,
+  indexName,
+  id,
+  namespace,
+  attribute,
+}) {
+  const index = searchState.indices[indexName];
+
+  if (namespace && index) {
+    return {
+      ...searchState,
+      indices: {
+        ...searchState.indices,
+        [indexName]: {
+          ...index,
+          [namespace]: omit(index[namespace], attribute),
+        },
+      },
+    };
+  }
+
+  return omit(searchState, `indices.${indexName}.${id}`);
 }
diff --git a/packages/react-instantsearch/src/core/indexUtils.test.js b/packages/react-instantsearch/src/core/indexUtils.test.js
@@ -511,6 +511,29 @@ describe('utility method for manipulating the search state', () => {
         page: 1,
         namespace: {},
       });
+
+      // It might happen that we try to cleanUp an index that is not
+      // present on the searchState. We should not throw an error in
+      // that case, just return the searchState as it is.
+      searchState = {
+        page: 1,
+        indices: {
+          second: {
+            page: 1,
+          },
+        },
+      };
+
+      searchState = cleanUpValue(searchState, context, 'menu.category');
+
+      expect(searchState).toEqual({
+        page: 1,
+        indices: {
+          second: {
+            page: 1,
+          },
+        },
+      });
     });
 
     it('get results', () => {