feat(refreshcache): minor updates

algolia · Nov 20, 2017 · 1f6cdaa · 1f6cdaa
1 parent 72d865c
commit 1f6cdaa
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 29 deletions.
diff --git a/packages/react-instantsearch/src/core/InstantSearch.js b/packages/react-instantsearch/src/core/InstantSearch.js
@@ -177,7 +177,7 @@ InstantSearch.propTypes = {
 
   createURL: PropTypes.func,
 
-  refresh: PropTypes.bool,
+  refresh: PropTypes.bool.isRequired,
 
   searchState: PropTypes.object,
   onSearchStateChange: PropTypes.func,

diff --git a/packages/react-instantsearch/src/core/InstantSearch.test.js b/packages/react-instantsearch/src/core/InstantSearch.test.js
@@ -25,6 +25,7 @@ const DEFAULT_PROPS = {
   root: {
     Root: 'div',
   },
+  refresh: false,
 };
 
 describe('InstantSearch', () => {
@@ -265,7 +266,7 @@ describe('InstantSearch', () => {
 
     createInstantSearchManager.mockImplementation(() => ism);
 
-    const wrapper = mount(
+    const wrapper = shallow(
       <InstantSearch {...DEFAULT_PROPS}>
         <div />
       </InstantSearch>
@@ -295,7 +296,7 @@ describe('InstantSearch', () => {
 
     createInstantSearchManager.mockImplementation(() => ism);
 
-    const wrapper = mount(
+    const wrapper = shallow(
       <InstantSearch {...DEFAULT_PROPS}>
         <div />
       </InstantSearch>

diff --git a/packages/react-instantsearch/src/core/createInstantSearch.js b/packages/react-instantsearch/src/core/createInstantSearch.js
@@ -24,7 +24,7 @@ export default function createInstantSearch(defaultAlgoliaClient, root) {
       searchParameters: PropTypes.object,
       createURL: PropTypes.func,
       searchState: PropTypes.object,
-      refresh: PropTypes.bool,
+      refresh: PropTypes.bool.isRequired,
       onSearchStateChange: PropTypes.func,
       onSearchParameters: PropTypes.func,
       resultsState: PropTypes.oneOfType([PropTypes.object, PropTypes.array]),

diff --git a/stories/RefreshCache.stories.js b/stories/RefreshCache.stories.js
@@ -4,41 +4,20 @@ import { InstantSearch, SearchBox } from '../packages/react-instantsearch/dom';
 import { CustomHits } from './util';
 
 const stories = storiesOf('RefreshCache', module);
-const buttonStyle = {
-  borderRadius: '4px',
-  padding: '10px',
-  border: 'none',
-  fontSize: '12px',
-  cursor: 'pointer',
-  color: '#fff',
-  background: '#3369e7',
-};
-
-const divStyle = {
-  borderRadius: '2px',
-  padding: '10px',
-  marginTop: '15px',
-  border: 'none',
-  fontSize: '12px',
-  color: '#999999',
-  background: '#F3F3F3',
-  display: 'block',
-};
 
 class AppWithRefresh extends Component {
   constructor(props) {
     super(props);
     this.state = {
       refresh: false,
     };
-    this.refresh = this.refresh.bind(this);
   }
 
-  refresh() {
+  refresh = () => {
     this.setState(prevState => ({
       refresh: !prevState.refresh,
     }));
-  }
+  };
 
   onSearchStateChange = () => {
     this.setState({ refresh: false });
@@ -112,10 +91,33 @@ class AppWithRefresh extends Component {
             placeholder: 'Search our furnitures: chairs, tables etc.',
           }}
         />
-        <button onClick={this.refresh} style={buttonStyle}>
+        <button
+          onClick={this.refresh}
+          style={{
+            borderRadius: '4px',
+            padding: '10px',
+            border: 'none',
+            fontSize: '12px',
+            cursor: 'pointer',
+            color: '#fff',
+            background: '#3369e7',
+          }}
+        >
           Refresh cache
         </button>
-        <button style={divStyle} disabled>
+        <button
+          style={{
+            borderRadius: '2px',
+            padding: '10px',
+            marginTop: '15px',
+            border: 'none',
+            fontSize: '12px',
+            color: '#999999',
+            background: '#F3F3F3',
+            display: 'block',
+          }}
+          disabled
+        >
           Refresh is set to: <em>{displayRefresh}</em>
         </button>