This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 386
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
vvo
committed
Aug 1, 2017
1 parent
f73eb04
commit a80dcd5
Showing
1 changed file
with
75 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @rarkins strangely when launching yarn locally these changes needed to be made, no idea why
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vvo that is indeed strange. Renovate is using a prebuilt 0.27.5 of yarn which appears to be the latest. I'll take a closer look soon.
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also were using v0.27.5
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah maybe it's because we use yarn link in our boot script https://github.com/algolia/react-instantsearch/blob/a80dcd5db3a4c9d595a83c63aa6b190927084b3d/scripts/boot.sh
So:
yarn
yarn link ...
yarn => ends up with those deps
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vvo thanks for that, I'm sure it would have taken me hours to find it.
So the question is, how can we get Renovate following the same thing? Finding - let alone executing -arbitrary
.shscripts seems out of the question.For now, I'm a little stumped, because
(a) That seems to be an arbitrary shell script that Renovate can't possibly find on its own
(b) Even if it were to find it, I don't think Renovate can ever allow arbitrary shell scripts to run (very hard to sandbox)
(c) It seems you need these packages in the
yarn.lock?I haven't used
yarn linkor any equivalent in npm myself though so I'm assuming (c) is true.My first thought is to expose some type of "yarn link" configuration where you can specify directories and parameters - that way it should be "safe" to run. But then you'd also be duplicating your shell script and need to keep them in sync.
BTW here was the last time Renovate updated this
yarn.lock: https://github.com/algolia/react-instantsearch/pull/218/files and it seems OKa80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we sould just not try to update the yarn.lock file inside our boot script and that should solve it the right way®
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, the way you have this project set up reminds me a little of what the upcoming Yarn Workspaces release is trying to achieve. Check out this draft blog post if you haven't seen it already: https://github.com/yarnpkg/website/blob/e281e8a75c64eb9d918ffbe183435e4e80ffcdc6/_posts/2017-07-26-introducing-workspaces.md
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, I just coincidentally noticed you guys power the yarn search infrastructure :)
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we have a monorepo situation here, but are waiting a bit, since we had troubles with lerna before. Hopefully yarn workspaces will make our life easier
a80dcd5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haroenv great. Lerna is currently supported by Renovate, Workspaces is not and the issue can be tracked here: renovatebot/renovate#473. Please let me know if/when you're considering implementing if the issue is not yet in progress, I'd be happy to work with you to make sure it's ready/working.