Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Docs for Highlighter: separatorComponent should be separator #803

Closed
Greenie10 opened this issue Jan 5, 2018 · 1 comment
Closed

Docs for Highlighter: separatorComponent should be separator #803

Greenie10 opened this issue Jan 5, 2018 · 1 comment

Comments

@Greenie10
Copy link
Contributor

In the documentation for Highlighter, the Prop separatorComponent should be separator as declared in the Highlighter.js component in GitHub - or perhaps the Highlighter.js file should be edited to say separatorComponent, which I think I prefer :)

Greenie10 added a commit to Greenie10/react-instantsearch that referenced this issue Jan 6, 2018
Correct `separatorComponent` prop name to `separator` as per algolia#803
Greenie10 added a commit to Greenie10/react-instantsearch that referenced this issue Jan 6, 2018
Correct `separatorComponent` prop name to `separator` as per algolia#803
This was referenced Jan 6, 2018
@Greenie10
Copy link
Contributor Author

Have also updated the PropTypes in Highlight and Snippet components, as per @samouss request.

samouss pushed a commit that referenced this issue Jan 8, 2018
* Update prop name

Correct `separatorComponent` prop name to `separator` as per #803

* Update PropTypes on Highlight component
samouss pushed a commit that referenced this issue Jan 8, 2018
* Update prop name

Correct `separatorComponent` prop name to `separator` as per #803

* Update PropTypes on Snippet component
@samouss samouss closed this as completed Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants