Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

[HierarchicalMenu] limit gets applied before transformItems #92

Closed
Haroenv opened this issue May 15, 2017 · 0 comments
Closed

[HierarchicalMenu] limit gets applied before transformItems #92

Haroenv opened this issue May 15, 2017 · 0 comments
Labels
Difficulty: ❄️ easy Type: ❤️ Bug

Comments

@Haroenv
Copy link
Contributor

Haroenv commented May 15, 2017 •
edited by mthuret
Loading

Do you want to request a feature or report a bug?

bug

Bug: What is the current behavior?

The values get truncated by transformValue before the transformItems is applied, that means that the truncation will change the sort

see connectHierarchicalMenu.js#L188-L193

Bug: What is the expected behavior?

transformItems to be applied before transformValue, or the showMore truncation to happen after transformItems

cc @JStonevalley
@marielaures marielaures mentioned this issue Oct 11, 2017
Merged
@vvo vvo closed this as completed in fe178ed Oct 16, 2017
samouss added a commit that referenced this issue Nov 2, 2017
@samouss
v4.2.0
062d0de 
<a name="4.2.0"></a>
# [4.2.0](v4.1.3...v4.2.0) (2017-11-02)

### Bug Fixes

* **connectRange:** handle boundaries on first call ([9f14dc0](9f14dc0))
* **connectRange:** use refine instead of cleanUp in metadata ([#526](#526)) ([1861235](1861235))
* **hierarchicaMenu:** allow sorting and using limit ([fe178ed](fe178ed)), closes [#92](#92)
* **InfiniteHits:** add disabled style to the LoadMore button ([#477](#477)) ([faba1ad](faba1ad))
* **Range:** handle float, allow reset and respect boundaries ([75969b8](75969b8))
* **RangeInput:** fix compatibility with React 16 & Panel ([3f218db](3f218db))
* **searchbox:** add maxlength 512 ([#542](#542)) ([5bd4033](5bd4033)), closes [#510](#510)

### Features

* **MenuSelect:** add component and connector ([cc6e0d7](cc6e0d7))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: ❄️ easy Type: ❤️ Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bobylito @Haroenv @mthuret