This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(geo): add stories [PART-9] #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit a9efc4f https://deploy-preview-1236--react-instantsearch.netlify.com |
samouss
force-pushed
the
feat/geo-part-8-marker-options
branch
from
5e77b01 to
ace15e8
Compare
samouss
force-pushed
the
feat/geo-part-9-stories
branch
from
258eec4 to
cfe5d31
Compare
samouss
force-pushed
the
feat/geo-part-8-marker-options
branch
from
ace15e8 to
7b63aa2
Compare
samouss
force-pushed
the
feat/geo-part-9-stories
branch
2 times, most recently
from
a1fa130 to
f6c5271
Compare
samouss
force-pushed
the
feat/geo-part-8-marker-options
branch
from
7b63aa2 to
d1267d2
Compare
samouss
force-pushed
the
feat/geo-part-9-stories
branch
from
f6c5271 to
064f873
Compare
* chore(docs): increse padding to avoid crop table on API page * chore(docs): restore margin on code sample * chore(docs): add a specific className for multi components API * docs(GeoSearch) * docs(GeoSearch): rename HTMLMarker to CustomMarker * docs(GeoSearch): rename package * chore(maps): update package description * fi(GeoSearch): update Storybook link * docs(GeoSearch): update wording
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
* feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
* feat(geo): add Redo component [PART-4] (#1201) * feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 20, 2018
* feat(geo): add refine on interaction [PART-3] (#1192) * feat(geo): add Redo component [PART-4] (#1201) * feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jun 21, 2018
* feat(geo): add simple GoogleMaps widget [PART-2] (#1189) * feat(geo): add refine on interaction [PART-3] (#1192) * feat(geo): add Redo component [PART-4] (#1201) * feat(geo): add Control component [PART-5] (#1205) * feat(geo): refactor & external update [PART-6] (#1207) * feat(geo): custom Marker [PART-7] (#1214) * feat(geo): add Marker & HTMLMarker interactions [PART-8] (#1227) * feat(geo): add stories [PART-9] (#1236) * feat(geo): add docs [PART-10] (#1289)
samouss
added a commit
that referenced
this pull request
Jul 4, 2018
<a name="5.2.0"></a> # [5.2.0](v5.2.0-beta.2...v5.2.0) (2018-07-04) ### Bug Fixes * **translatable:** avoid create a new function on every render ([#1383](#1383)) ([1285b3b](1285b3b)) ### Features * **core:** export translatable ([#1351](#1351)) ([6d5a89d](6d5a89d)) * **maps:** add connector & widget ([#1171](#1171)) ([16e288a](16e288a)), closes [#1189](#1189) [#1192](#1192) [#1201](#1201) [#1205](#1205) [#1207](#1207) [#1214](#1214) [#1227](#1227) [#1236](#1236) [#1289](#1289)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is PR adds two stories:
InfoWindowwith markersThis PR also introduce an option to render a custom Hits component with
<WrapWithHits />. It's a bit hard to extend the wrapper component with the current implementation. In the upcoming months, it might worth it to have a more coherent showcase cross InstantSearch flavors.Result
You can use them in Storybook.