-
Notifications
You must be signed in to change notification settings - Fork 386
feat(voiceSearch): add voice search widget #2316
Conversation
Deploy preview for react-instantsearch ready! Built with commit d0b843d https://deploy-preview-2316--react-instantsearch.netlify.com |
This is a draft pull request to check if the implementation is okay for VoiceSearch.tsxThis components receives props from connector like
When user clicks the button, it will execute This component also receives these two props.
It is to let user customise the UI like the way we provide templates in InstantSearch.js. connectVoiceSearchThis is a tricky part. We have To achieve this, For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I haven't tried it out yet, but have some code style comments
packages/react-instantsearch-core/src/connectors/connectVoiceSearch.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the connector tests to review everything.
packages/react-instantsearch-core/src/connectors/connectVoiceSearch.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/lib/voiceSearchHelper/index.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/lib/voiceSearchHelper/index.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/lib/voiceSearchHelper/index.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/lib/voiceSearchHelper/index.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/__tests__/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/__tests__/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/__tests__/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/__tests__/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: eunjae-lee <karis612@gmail.com>
…earch into feat/voice-search
…ing for setSearchAsYouSpeak
packages/react-instantsearch-dom/src/components/__tests__/VoiceSearch.tsx
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/lib/voiceSearchHelper/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one small comment about file organisation
I can't see the custom button example |
Right. That's fixed at 9656c5a |
# [5.7.0](v5.6.0...v5.7.0) (2019-06-04) ### Bug Fixes * **highlight:** allow array as "attribute" ([#2474](#2474)) ([9dc829a](9dc829a)), closes [#2461](#2461) * **indexUtils:** allow index with dots in it ([#2350](#2350)) ([f91906f](f91906f)) ### Features * **voiceSearch:** add voice search widget ([#2316](#2316)) ([0e3b124](0e3b124))
Summary
This adds a new widget, connector and component for voice search.
Usage
Checklist
connector(usingconnectSearchBox
)