This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(hooks): mount widgets in SSR to retrieve HTML #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d81a7d5:
|
Haroenv
reviewed
Jun 14, 2022
packages/react-instantsearch-hooks-server/src/__tests__/getServerState.test.tsx
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for react-instantsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Haroenv
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our SSR APIs as reported in #3511.
During the
useSyncExternalStore()migration in #3489, we omitted some SSR checks by removing theserverState.initialResultscondition. This was responsible for mounting the widgets during rendering, to then render them on the server. We now also cover the generated HTML with a test.Note that this solution doesn't work with Strict Mode, as it wasn't prior to the bug. This is just a fix to release early, and then we'll work on Strict Mode support.
Closes #3511