Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect conventional commits for breaking changes #634

Closed
eunjae-lee opened this issue Jan 23, 2020 · 0 comments
Closed

respect conventional commits for breaking changes #634

eunjae-lee opened this issue Jan 23, 2020 · 0 comments

Comments

@eunjae-lee
Copy link
Contributor

https://www.conventionalcommits.org/en/v1.0.0/#examples
@eunjae-lee eunjae-lee mentioned this issue Feb 17, 2020
Merged
Haroenv added a commit that referenced this issue Feb 17, 2020
@Haroenv
WIP: detect major versions correctly
5fb5146 
I haven't tested this yet, but it should work I think

see #634
@Haroenv Haroenv mentioned this issue Feb 17, 2020
Merged
eunjae-lee added a commit that referenced this issue Feb 24, 2020
@Haroenv @eunjae-lee
fix: detect major versions correctly (#666)
5c5cca1 
* WIP: detect major versions correctly

I haven't tested this yet, but it should work I think

see #634

* Update packages/shipjs-lib/src/lib/util/getNextVersion.js

Co-authored-by: Eunjae Lee <karis612@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eunjae-lee