Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update path to conventional-changelog binary #425

Merged
merged 3 commits into from
Nov 22, 2019
Merged

fix: update path to conventional-changelog binary #425

merged 3 commits into from
Nov 22, 2019

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Nov 19, 2019 •
edited
Loading

fix #399

I tested prepare command with npm and yarn, both is working now

Problem was in npm, npm don't link child bin dependencies in node_modules and yarn does

yarn:
Снимок экрана 2019-11-20 в 10 02 44

npm:
Снимок экрана 2019-11-20 в 10 08 29

@jeetiss jeetiss changed the title fix updating the changelog with npm fix: update path to conventional-changelog binary Nov 20, 2019
eunjae-lee
eunjae-lee approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense.
Thanks !

@eunjae-lee eunjae-lee merged commit 75d9994 into algolia:master Nov 22, 2019
@jeetiss
Copy link
Contributor Author

jeetiss commented Nov 22, 2019

Уряяяя 🕺🏻🎉🎉🎉🕺🏻

@jeetiss jeetiss deleted the fix-prepare-f-with-npm branch November 22, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee eunjae-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed release:prepare -f with npm
2 participants
@jeetiss @eunjae-lee