Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Powered-by component is not SSR compatible #367

Closed
Jexordexan opened this issue Dec 4, 2017 · 5 comments · Fixed by #368
Closed

Powered-by component is not SSR compatible #367

Jexordexan opened this issue Dec 4, 2017 · 5 comments · Fixed by #368

Comments

@Jexordexan
Copy link
Contributor

Do you want to request a feature or report a bug?

bug

Steps:

  • Create an empty nuxt starter project and install vue-instantsearch

  • add an <ais-powered-by> component into one of the templates

  • run npm run dev

  • visit the page with the component and notice the error screen saying location is undefined

Bug: What is the current behavior?

<ais-powered-by> is not SSR compatible,

Bug: What is the expected behavior?

The component should be compatible with ssr

Bug: What browsers are impacted? Which versions?

This is an SSR issue, so node.js?

Bug: What is the proposed solution?

Add a null check for the location object

What is the version you are using? Always use the latest one before opening a bug issue.

1.3.2

@Jexordexan Jexordexan reopened this Dec 4, 2017
@Haroenv
Copy link
Contributor

Haroenv commented Dec 4, 2017

Oh thanks for noticing that. Feel free to add a pr if you want

@Jexordexan
Copy link
Contributor Author

I'll try to leave a PR tonight! for now I've wrapped it in a nuxt no-ssr component

Jexordexan pushed a commit to Jexordexan/vue-instantsearch that referenced this issue Dec 4, 2017
Add a null check to the `location` reference in `algoliaUrl`.

fixes algolia#367
rayrutjes added a commit that referenced this issue Dec 4, 2017
fix: Powered-by component is not SSR compatible #367
@rayrutjes
Copy link
Member

Hey @Jexordexan , this is now release in v1.3.3

Let me know if it works out properly now.

Thanks for your work!

@ishitatsuyuki
Copy link

Please reopen. Error: location is undefined. We need to check it more strictly.

@Haroenv
Copy link
Contributor

Haroenv commented Sep 21, 2018

Hmm @ishitatsuyuki, are you using the latest version? The PR has been merged to fix this almost a year ago. Can you give a GitHub project where you receive this error?

Haroenv pushed a commit to algolia/instantsearch that referenced this issue Dec 28, 2022
Haroenv pushed a commit to algolia/instantsearch that referenced this issue Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants