Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

fix(Stats): use computed property for conditional rendering #331

Closed
wants to merge 1 commit into from
Closed

fix(Stats): use computed property for conditional rendering #331

wants to merge 1 commit into from

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Oct 17, 2017

Summary

Fix #330

@rayrutjes
Copy link
Member

Thanks for the PR.
I did one as well adding tests to ensure this does not break again: #332
I think it is better to only do the toLocaleString at display time and not introduce more to the component.

WDYT?

@samouss
Copy link
Contributor Author

samouss commented Oct 17, 2017

Close in favor of #332.

@samouss samouss closed this Oct 17, 2017
@samouss samouss deleted the fix/stats-visible branch October 17, 2017 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rayrutjes rayrutjes Awaiting requested review from rayrutjes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samouss @rayrutjes