Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(store): expose userData through a new getter #403

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

rayrutjes
Copy link
Member

@rayrutjes rayrutjes commented Mar 9, 2018

cc @ehayman

I'm wondering if we should always return an empty array in case no data is available or if we should leave this check up to the user.

@rayrutjes rayrutjes requested a review from Haroenv March 9, 2018 10:37
@ehayman
Copy link
Contributor

ehayman commented Mar 9, 2018

Good point... I think in this case, returning the empty array would be safest / simplest

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undefined is the good behaviour imo

@rayrutjes rayrutjes merged commit 3f32a31 into master Mar 9, 2018
@rayrutjes rayrutjes deleted the feat/expose-userdata branch March 9, 2018 14:26
@rayrutjes
Copy link
Member Author

@ehayman, I'll let @Haroenv handle the release whenever he sees fit.

Undefined is the good behaviour imo

I agree with that, let's stay as close as possible to the helper behaviour.

You will need to check if the returned value is undefined or not.

@Haroenv
Copy link
Contributor

Haroenv commented Mar 9, 2018

I’ll release next week!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants