This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(vue 3): provide default value for injected data #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d264846:
|
Haroenv
reviewed
Jun 9, 2021
| getProvidedParentIndex: '$_ais_getParentIndex', | ||
| getProvidedParentIndex: { | ||
| from: '$_ais_getParentIndex', | ||
| default: undefined, |
There was a problem hiding this comment.
the default parent index should be InstantSearchInstance.mainIndex
Haroenv
reviewed
Jun 9, 2021
| @@ -11,7 +11,10 @@ export const createWidgetMixin = ({ connector } = {}) => ({ | |||
| ); | |||
| }, | |||
| }, | |||
| getProvidedParentIndex: '$_ais_getParentIndex', | |||
| getProvidedParentIndex: { | |||
There was a problem hiding this comment.
Suggested change
| getProvidedParentIndex: { | |
| getParentIndex: { |
|
@Haroenv I'm closing this PR. It was a modification based on this workaround but now that I opened a PR for the fix on Vue.js side, it will resolve our issue. Sorry for your time! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds default value for
getProvidedParentIndex. Without default value, we get this warning messages: