feat: first/last valid on SendTransactionParams #292
Conversation
| @@ -194,6 +194,9 @@ export const sendTransaction = async function ( | |||
| const { transaction, from, sendParams } = send | |||
| const { skipSending, skipWaiting, fee, maxFee, suppressLog, maxRoundsToWaitForConfirmation, atc } = sendParams ?? {} | |||
|
|
|||
| if (sendParams?.firstValid) transaction.firstRound = sendParams.firstValid | |||
There was a problem hiding this comment.
Should we also add it to sendAtomicTransactionComposer, from memory it's a different code path, but a bit hazy on it.
Also, we should add this to the legacyTransactionBridge in #287
There was a problem hiding this comment.
Well we can't really add it to sendAtomicTransactionComposer because it's a transaction-specific field. Setting it on sendAtomicTransactionComposer would basically force us to update ALL the transactions with the specified lv/fv which we might not want.
There was a problem hiding this comment.
Yeah, that makes sense, I think I'm just getting confused about the code paths
src/types/transaction.ts
Outdated
| /** The first round this transaction will be valid */ | ||
| firstValid?: number | ||
| /** The last round this transaction will be valid */ | ||
| lastValid?: number |
There was a problem hiding this comment.
Should we indicate these are optional and by default are populated based on getSuggestedParams?
There was a problem hiding this comment.
Yeah good point. Let me know what you think of 623edb0
There was a problem hiding this comment.
Looks good, noting most methods also allow you to pass in suggested params as an override to avoid the algod call, but maybe that detail doesn't matter
Proposed Changes
Simply adds first and last valid to SendTransactionParams