Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return/accept string as address in AccountManager methods #304

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Aug 9, 2024

Proposed Changes

  • All AccountManager methods now accept/return a string. The idea being that most users don't have to think about signers/account objects since all the places they use account accept a string as an argument and the AccountManager will figure out the signer automatically

Discussion Points

  • It should be noted that this now creates a discrepancy between the test fixture and AccountManager methods, since the test fixture returns account objects. I'd propose that we essentially create new test fixture objects and deprecate the current ones, but open to other ideas.

@joe-p joe-p marked this pull request as draft August 9, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant