fix: fix inner transaction validation to handle some cases that were accidentally missed

[daniel-makerx]

No description provided.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/puya
__main__.py	31	1	97%	116
arc4_util.py	119	9	92%	73, 81, 93, 106–107, 121, 133, 135, 194
arc32.py	124	2	98%	108, 222
client_gen.py	106	106	0%	1–194
compile.py	211	20	91%	168–171, 183–184, 193–194, 205, 212–213, 230–240, 250–252, 257, 333–334
context.py	40	1	98%	48
errors.py	45	17	62%	43–53, 65–71
log.py	212	31	85%	36–39, 72, 74, 92, 111, 126–127, 169–171, 174–176, 178, 191–200, 222, 292–294, 303–304, 338, 355
parse.py	222	11	95%	96, 108, 133, 227, 318–323, 327, 425–426, 429
utils.py	162	20	88%	52, 56, 90, 96, 111, 114–116, 123, 145, 158–159, 163, 167–170, 199, 201, 224, 254
src/puya/awst
nodes.py	909	45	95%	90, 94–97, 137, 141–144, 524, 730, 763, 807–808, 871, 975, 1017, 1037, 1088, 1093, 1193, 1341, 1394–1395, 1402–1407, 1449, 1532, 1582, 1586, 1631, 1644, 1686, 1729, 1740, 1742, 1747, 1755, 1760, 1765, 1774, 1779, 1784, 1791
to_code_visitor.py	323	3	99%	108, 325, 506
wtypes.py	290	26	91%	21, 185–196, 211–214, 231, 233, 278, 310, 313, 315, 318, 396, 445–446, 455–456, 464–465, 479
src/puya/awst_build
arc4_utils.py	148	34	77%	50, 52, 55, 67, 94, 110, 114, 117, 123, 126, 129, 132, 138, 140, 148, 151, 154–166, 169, 178, 181, 264, 346
base_mypy_visitor.py	129	40	69%	70–76, 94, 102–115, 129, 131, 133, 145, 150, 154, 157, 160, 166, 187, 192, 195, 198, 205, 209, 212, 215, 219, 237, 241, 245, 249, 253, 257, 261, 265, 269, 273, 277, 281, 285
context.py	140	14	90%	62–63, 145, 147–151, 154–155, 175, 180, 184, 211
contract.py	222	53	76%	131–132, 134–137, 145–146, 149, 161, 172, 194, 218, 220, 229, 239, 248, 276, 280, 296–300, 308, 317, 320, 323, 328–329, 332, 340, 343, 346, 349, 352, 355, 358, 361, 364, 392–399, 408–415, 422–423, 446, 456, 464, 470, 492–498
intrinsic_factory.py	31	2	94%	82–84
intrinsic_models.py	35	1	97%	22
main.py	48	3	94%	31, 48, 58
module.py	400	79	80%	75, 143, 157–159, 173–174, 181, 189, 195, 201–205, 210, 222, 247–248, 259, 289, 315–316, 339, 346, 368–369, 392–397, 451–452, 480, 491, 494, 500, 513, 519, 531, 534, 556, 577, 583, 592–595, 613–648, 672, 680–681, 695–697, 699, 701–702, 727, 735, 737
subroutine.py	602	54	91%	271, 277, 345, 354, 368, 409, 552–567, 575, 583, 627–628, 633, 675, 695–696, 720–727, 779, 785, 801, 807, 815–818, 872, 876–877, 881–882, 900, 903, 930, 939, 975, 1017, 1045, 1049, 1149, 1177, 1184, 1194, 1205–1209, 1218, 1221, 1224, 1227, 1230, 1251
utils.py	164	11	93%	40, 77, 95–96, 100, 143–144, 163, 175, 231, 252
src/puya/awst_build/eb
app_account_state.py	127	27	79%	51–54, 62, 78, 80, 112–113, 134–141, 162–163, 168, 175–176, 178, 195–196, 203–204, 233, 238–239
app_state.py	120	21	82%	52–59, 80–81, 86, 99–100, 105, 122–123, 130–131, 172–173, 196, 214
array.py	67	44	34%	26–27, 30–32, 37–44, 56–72, 77–79, 82, 85–88, 93–95, 100–102, 111–123
base.py	177	45	75%	125, 131–136, 147–153, 158–164, 172, 178, 188, 198, 202, 208, 222, 227, 232, 235, 238, 241, 246, 249, 292, 295, 300, 303, 306, 309, 312, 317, 320, 354, 388, 393, 402, 409, 416, 419, 422, 427, 434, 439, 445
biguint.py	82	4	95%	129, 146–149
bool.py	36	3	92%	53–54, 72
bytes.py	125	11	91%	89–90, 110–111, 115, 119, 124, 126, 169, 261–262
bytes_backed.py	30	4	87%	37–38, 50–51
contracts.py	44	2	95%	57, 61
ensure_budget.py	44	12	73%	49–50, 70–71, 79, 91, 97–102
log.py	46	5	89%	79–85, 95
named_int_constants.py	20	2	90%	23–24
string.py	119	8	93%	101–102, 129–130, 185, 243–244, 259
struct.py	29	13	55%	20–21, 24, 33, 38–40, 43–48
subroutine.py	51	5	90%	48, 63, 89, 92, 107
template_variables.py	47	11	77%	25–26, 41, 59–60, 64, 69, 72–73, 82–83
tuple.py	98	20	80%	38–39, 46, 57, 59–60, 82–83, 92–93, 106, 112, 130–131, 136–137, 149, 157, 165, 199
type_registry.py	27	1	96%	151
uint64.py	72	1	99%	144
unsigned_builtins.py	66	8	88%	51, 58, 92, 95–96, 126, 129–130
value_proxy.py	39	10	74%	24, 30, 33, 36, 41, 56, 66, 75, 84, 90
src/puya/awst_build/eb/arc4
utils.py	139	15	89%	55–56, 58, 61–62, 84–85, 115, 169, 175, 180–182, 226, 231
abi_call.py	184	18	90%	107–108, 112–113, 152, 170, 210, 219–220, 263, 313–319, 352–353, 433, 435
arrays.py	237	22	91%	97–98, 117, 149, 162–163, 187, 191, 250–251, 264, 313–314, 367–368, 390, 400–401, 465–466, 520, 557
base.py	85	10	88%	66–67, 116–117, 137, 146, 164–165, 185, 190
bool.py	26	2	92%	46–47
dynamic_bytes.py	39	2	95%	68–69
emit.py	29	2	93%	60–61
numeric.py	109	8	93%	73, 80–81, 139–140, 146, 207–208
string.py	62	8	87%	58, 87, 106–107, 132–133, 151–152
struct.py	53	5	91%	65, 68, 71, 97–98
tuple.py	64	11	83%	36, 44, 57, 61–62, 83, 92, 109–110, 120–121
src/puya/awst_build/eb/reference_types
account.py	67	1	99%	133
application.py	31	1	97%	42
asset.py	52	3	94%	48, 89–90
base.py	41	1	98%	87
src/puya/awst_build/eb/transaction
base.py	25	3	88%	33–34, 41
group.py	53	4	92%	87–88, 146–147
inner.py	51	4	92%	64–65, 115, 142
inner_params.py	100	8	92%	43–44, 54, 115, 150, 174, 190, 222
src/puya/awst_build/validation
base_invoker.py	29	5	83%	31, 38, 47–52
inner_transactions.py	180	1	99%	159
scratch_slots.py	39	4	90%	19, 33, 49, 51
src/puya/ir
arc4_router.py	244	17	93%	131, 149, 157, 309, 485–486, 500, 541–542, 554, 559, 564, 569, 574, 579, 599–603
avm_ops.py	315	1	99%	46
avm_ops_models.py	48	3	94%	21, 30, 38
context.py	86	7	92%	72, 93–99, 104, 115, 132
main.py	218	1	99%	432
models.py	501	18	96%	67, 176, 183, 308, 385, 429, 456, 511, 553, 633, 649, 690, 693, 700, 703, 793–794, 817
ssa.py	130	2	98%	51–52
to_text_visitor.py	149	9	94%	93, 98, 182–183, 189–194
types.py	106	15	86%	49–50, 56, 88–91, 102, 118, 142–145, 177–180
visitor.py	119	15	87%	171, 183, 198, 201, 207, 213, 216, 227, 230, 233, 236, 239, 242, 245, 248
visitor_mutator.py	101	2	98%	152–153
vla.py	72	1	99%	87
src/puya/ir/builder
_utils.py	76	7	91%	78, 157, 204, 237, 240–242
arc4.py	422	37	91%	78, 163–168, 235–236, 486, 643–657, 989–1003, 1029–1052, 1062–1077, 1101, 1265–1282, 1321–1322, 1372, 1405, 1554–1555, 1618
assignment.py	56	7	88%	67, 80, 107, 127, 145, 161–162
blocks.py	84	2	98%	155, 163
bytes.py	64	14	78%	23–55, 139
callsub.py	57	1	98%	93
iteration.py	191	4	98%	46, 69, 95, 183
itxn.py	263	11	96%	122–123, 125, 138, 186, 206, 231–232, 558, 596–597
main.py	468	35	93%	98, 160, 164, 209, 226, 272, 406, 428–431, 447–448, 488, 514, 555–558, 568, 633, 751, 764, 801, 877, 880, 888, 891–892, 899, 930, 992, 1009, 1059–1060
src/puya/ir/destructure
coalesce_locals.py	102	20	80%	119, 128–129, 132–135, 138–147, 163–166
parcopy.py	84	2	98%	47, 83
src/puya/ir/optimize
collapse_blocks.py	92	5	95%	65–69
control_op_simplification.py	101	10	90%	159–166, 240–247
inner_txn.py	36	1	97%	38
intrinsic_simplification.py	418	30	93%	68, 171, 183, 208, 250, 317, 375, 381, 455, 483, 504, 506, 512, 521, 565, 567, 569, 576, 606, 612, 614, 616, 621, 623, 625, 627, 629, 681–682, 689
main.py	86	3	97%	111–112, 128
src/puya/ir/validation
_base.py	30	2	93%	24–25
min_avm_version_validator.py	11	1	91%	15
op_run_mode_validator.py	20	6	70%	19–30
src/puya/mir
annotaters.py	159	2	99%	62, 212
builder.py	130	7	95%	239–240, 293, 296, 299, 302, 305
context.py	39	1	97%	35
models.py	328	16	95%	40, 52, 68, 77, 88, 99, 110, 150, 260, 291, 328, 340, 365–371
output.py	61	2	97%	29, 31
stack.py	250	19	92%	72, 119, 135, 146, 157, 167, 184, 201, 211, 230, 250, 256, 258, 297, 310, 334, 366, 371, 409
src/puya/mir/stack_allocation
baileys.py	205	3	99%	31, 330–334
frame_allocation.py	80	2	98%	21, 68
koopmans.py	61	1	98%	55
peephole.py	100	6	94%	75, 89, 99, 101, 103, 145
src/puya/teal/optimize
peephole.py	112	4	96%	154–164, 172
repeated_rotations.py	30	1	97%	13
repeated_rotations_search.py	88	6	93%	34, 40–41, 57, 67–68
TOTAL	16236	1337	92%

Tests	Skipped	Failures	Errors	Time
302	3 💤	0 ❌	0 🔥	2m 54s ⏱️