fix(ui): catch and handle 'stakers' box value 404 errors [reverted] #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling fetchStakedInfoForPool for a staking pool with no stakers (yet), attempting to fetch that pool contract's 'stakers' box value will return a 404 error. An error message is shown by StakingDetails.
Now we catch the error from getBoxValue('stakers') and if it's a 404, return an empty array.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
drichar
added a commit
that referenced
this pull request
May 22, 2024
* Revert "fix(ui): catch and handle 'stakers' box value 404 errors (#165)" This reverts commit 8cdafb1. * fix(ui): wait until step 2 to invalidate 'pools-info' query In the add pool workflow, the 'pools-info' query was being invalidated after step 1 when the pool is still in the "limbo" state before the storage MBR is paid. That's why fetchStakedInfoForPool was throwing a 404 error: the 'stakers' box value has not been set yet. This moves invalidation to step 2, after the box value has been set. No more error.
drichar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
fetchStakedInfoForPoolfor a staking pool with no stakers (yet), attempting to fetch that pool contract's 'stakers' box value will return a 404 error. An error message is shown byStakingDetails.Now we catch the error from
getBoxValue('stakers')and if it's a 404, return an emptyStakedInfoarray.