fix(ui): prevent incorrect update notifications #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cache-busting and no-cache headers to `version.json` fetch - Add detailed logging for version mismatches - Improve error handling in version check
- Add `isNewerVersion` helper to properly compare semver versions - Only show update toast when deployed version is newer - Update logging message to be more accurate - Handle versions with or without 'v' prefix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pbennett
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the version check system to prevent incorrect update notifications and adds better caching prevention. Previously, users could sometimes see update notifications for older versions due to (suspected) caching issues and imprecise version comparison.
Details
isNewerVersionhelper to properly compare semver versions