Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workspaceFolders search #8

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Added workspaceFolders search #8

merged 2 commits into from
Jan 24, 2021

Conversation

m4ss1m0g
Copy link
Contributor

@m4ss1m0g m4ss1m0g commented Jan 22, 2021

When open in a workspace the extension search on first workspace folder using the deprecated vscode.workspace.rootPath.
I have changed rootPath with the array string of all workspace folders.

Now the extension correctly read ALL workspace folders.

To test the actual behavior create a folder with this structure.

├── **my.code-workspace**
├── **mySolution.sln**
├── README.md
├── Docker
│   ├── Dockerfile
├── src
│   ├── Domain
│   │   ├── **Domain.csproj**
│   │   ├── bin
│   │   └── obj
│   ├── Infrastructure
│   │   ├── **Infrastructure.csproj**
│   │   ├── bin
│   │   └── obj
│   ├── NetCoreWeb
│   │   ├── **Web.csproj**
│   │   ├── Api
│   │   ├── Program.cs
│   │   ├── Startup.cs
│   │   ├── appsettings.json
│   │   ├── bin
│   │   ├── wwwroot
│   └── VueAPP
│       ├── node_modules
│       ├── package.json
│       ├── src
│       ├── tests
│       ├── tsconfig.json
│       ├── vue.config.js
│       └── yarn.lock
└── tests
    └── MyTests
        ├── **Test1.csproj**
        ├── Consts.cs
        ├── bin
        └── obj

Where the workspace is

{
	"folders": [
		{
			"path": "src\\VueAPP",
			"name": "🧃 VueJS"
		},
		{
			"path": "src\\Domain",
			"name": "🧱 Domain"
		},
		{
			"path": "src\\Infrastructure",
			"name": "🌉 Infrastructure"
		},
		{
			"path": "src\\NetCoreWeb",
			"name": "🕸️ Web"
		},
		{
			"path": "tests\\MyTests",
			"name": "🧪 Tests"
		},
		{
			"path": ".",
			"name": "🌵 Root"
		}
	]
}

Notice the last workspace node Root witch include ALL

@aliasadidev
Copy link
Owner

Thank you @m4ss1m0g.
I will add that ability as soon as I have some time.

@aliasadidev aliasadidev merged commit 3cb5642 into aliasadidev:main Jan 24, 2021
@m4ss1m0g m4ss1m0g deleted the workspaces branch February 25, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants