Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchMhlo] Add layernorm #479

Merged
merged 3 commits into from
Jul 26, 2022
Merged

[TorchMhlo] Add layernorm #479

merged 3 commits into from
Jul 26, 2022

Conversation

tanyokwok
Copy link
Collaborator

@tanyokwok tanyokwok commented Jul 19, 2022

Please also review pai-disc/torch-mlir#13

  1. Add layernorm decomposition in Add decomposition for aten::native_layer_norm pai-disc/torch-mlir#13
  2. Add layernorm e2e ut and filecheck

@tanyokwok tanyokwok force-pushed the tanyo/dev_layer_norm branch 2 times, most recently from c793df8 to 09d8af7 Compare July 19, 2022 06:48
@tanyokwok tanyokwok force-pushed the tanyo/dev_layer_norm branch 2 times, most recently from ad82412 to a378319 Compare July 25, 2022 10:41
Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanyokwok tanyokwok merged commit 5b38270 into main Jul 26, 2022
@tanyokwok tanyokwok deleted the tanyo/dev_layer_norm branch July 26, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants