Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(interactive): Return the correct http code #3700

Merged
merged 2 commits into from
Apr 9, 2024
Merged

refactor(interactive): Return the correct http code #3700

merged 2 commits into from
Apr 9, 2024

Conversation

zhanglei1949
Copy link
Collaborator

  • Internally use Result<> to store the runtime error, and map the error to http code at admin_http_handler.
  • Extract commonly used code into utils function http_utils.h.

@zhanglei1949 zhanglei1949 changed the title refactor(interactive): Refactor admin http handler refactor(interactive): Return the correct http error code Apr 9, 2024
@zhanglei1949 zhanglei1949 changed the title refactor(interactive): Return the correct http error code refactor(interactive): Return the correct http code Apr 9, 2024
@liulx20 liulx20 merged commit 12cbced into alibaba:main Apr 9, 2024
37 checks passed
@zhanglei1949 zhanglei1949 deleted the cor-http-code branch April 25, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luoxiaojian luoxiaojian luoxiaojian approved these changes

@liulx20 liulx20 liulx20 approved these changes

@longbinlai longbinlai Awaiting requested review from longbinlai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhanglei1949 @luoxiaojian @liulx20