Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Identify pk when it is fused with other predicates in IRCore #3723

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

BingqingLyu
Copy link
Collaborator

What do these changes do?

As titled.

Related issue number

Fixes #3722

Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary solution, which will soon be replaced by the new Gopt framework.
@BingqingLyu Can you add an issue for the Gopt replacement thing?

@BingqingLyu
Copy link
Collaborator Author

BingqingLyu commented Apr 22, 2024

This is a temporary solution, which will soon be replaced by the new Gopt framework. @BingqingLyu Can you add an issue for the Gopt replacement thing?

Yes and it can be found in #3736.

@siyuan0322 siyuan0322 merged commit 2fee487 into alibaba:main Apr 23, 2024
9 of 12 checks passed
@siyuan0322 siyuan0322 deleted the fix_pk_opt branch April 23, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IRCore cannot recognize pk when it is fused with other predicates
4 participants