Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interactive): Unify devcontainer.json of graphscope-dev and flex #3866

Merged
merged 15 commits into from
Jun 20, 2024

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented May 31, 2024

Currently Flex use a different dev container image from graphscope-dev, remove the flex/.devcontainer.json

Fix #3864

@zhanglei1949
Copy link
Collaborator Author

Fail to install dependencies due to apache/incubator-graphar#515

@@ -330,7 +336,7 @@ write_env_config() {

{
echo "export GRAPHSCOPE_HOME=${install_prefix}"
echo "export CMAKE_PREFIX_PATH=/opt/vineyard"
echo "export CMAKE_PREFIX_PATH=/opt/vineyard:/opt/graphscope/"
Copy link
Collaborator Author

@zhanglei1949 zhanglei1949 Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed by hiactor actor_codegen

siyuan0322
siyuan0322 previously approved these changes Jun 14, 2024
zhanglei1949 and others added 11 commits June 19, 2024 17:37
Committed-by: xiaolei.zl from Dev container

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
@zhanglei1949 zhanglei1949 merged commit b1c8cb0 into alibaba:main Jun 20, 2024
69 of 71 checks passed
@zhanglei1949 zhanglei1949 deleted the rm-flex-dev-container branch July 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive should (also) build from image graphscope-dev
3 participants