Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Start the service when switching graph context on Interactive #3910

Merged
merged 6 commits into from
Jun 14, 2024
Merged

feat: Start the service when switching graph context on Interactive #3910

merged 6 commits into from
Jun 14, 2024

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Jun 12, 2024 •
edited
Loading

What do these changes do?

  • Start the service when switching graph context
  • Move gsctl service <start/stop/status> from GLOBAL to GRAPH context
  • Move gsctl create/delete datasource/loaderjob from GRAPH to GLOBAL context
  • Display GRAPH_NAME(GRAPH_ID) in gsctl service status and gsctl use GRAPH/GLOBAL command
  • Return metadata when uploading file
  • Add Y/N interaction when deleting graph/storedproc/job resource

Related issue number

Fixes

@lidongze0629 lidongze0629 changed the title Start the service when switching graph context on Interactive feat: Start the service when switching graph context on Interactive Jun 12, 2024
zhanglei1949
zhanglei1949 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhanglei1949
zhanglei1949 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanglei1949 zhanglei1949 merged commit 626501f into alibaba:main Jun 14, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanglei1949 zhanglei1949 zhanglei1949 approved these changes

@liulx20 liulx20 liulx20 approved these changes

@longbinlai longbinlai Awaiting requested review from longbinlai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidongze0629 @zhanglei1949 @liulx20