Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Refine Query Timeout Configuration in GIE Doc #3917

Merged
merged 2 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/gie-standalone/templates/frontend/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ spec:
value: {{ .Values.extraConfig | quote }}
- name: WORKER_NUM
value: {{ .Values.pegasusWorkerNum | quote }}
- name: TIMEOUT
value: {{ .Values.pegasusTimeout | quote }}
- name: QUERY_TIMEOUT
value: {{ .Values.queryExecutionTimeoutMS | quote }}
- name: BATCH_SIZE
value: {{ .Values.pegasusBatchSize | quote }}
- name: OUTPUT_CAPACITY
Expand Down
4 changes: 2 additions & 2 deletions charts/gie-standalone/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ htapLoaderConfig: "v6d_modern_loader.json"
## Pegasus Config
pegasusWorkerNum: 2

pegasusTimeout: 240000

pegasusBatchSize: 1024

pegasusOutputCapacity: 16
Expand All @@ -46,6 +44,8 @@ frontendQueryPerSecondLimit: 2147483647

gremlinScriptLanguageName: "antlr_gremlin_traversal"

queryExecutionTimeoutMS: 3000000

## need by vineyard in distributed env
etcdEndpoint: "etcd-for-vineyard.default.svc.cluster.local:2379"

Expand Down
4 changes: 3 additions & 1 deletion docs/interactive_engine/dev_and_test.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ $GIE_TEST_HOME/bin/gaia_executor $GIE_TEST_HOME/conf/log4rs.yml $GIE_TEST_HOME/c
## Pegasus service config
# a.k.a. thread num
pegasus.worker.num = 1
pegasus.timeout = 240000
pegasus.batch.size = 1024
pegasus.output.capacity = 16

Expand All @@ -126,6 +125,9 @@ neo4j.bolt.server.port = 7687
# disable authentication if username or password is not set
# auth.username = default
# auth.password = default

# set total execution time for a query
query.execution.timeout.ms: 3000000
```

6. Start the `frontend`:
Expand Down
4 changes: 2 additions & 2 deletions docs/interactive_engine/getting_started.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ The number 6 is printed, which is the number of vertices in modern graph.
You could pass additional key-value pairs to customize the startup configuration of GIE, for example:

```python
# Set the timeout value to 10 min
g = gs.interactive(graph, params={'query.execution.timeout.ms': 600000})
# set total execution time for a query to 3000s
g = gs.interactive(graph, params={'query.execution.timeout.ms': 3000000})
```

## What's the Next
Expand Down
1 change: 1 addition & 0 deletions docs/storage_engine/groot.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ helm status demo
| frontend.replicaCount | Number of Frontend | 1 |
| frontend.service.type | Kubernetes Service type of frontend | NodePort |
| frontend.query.per.second.limit | the maximum qps can be handled by frontend service | 2147483647 (without limitation) |
| query.execution.timeout.ms | the total execution time for a query | 3000000 |


If Groot is launched with the default configuration, then two Store Pods, one Frontend Pod, and one Coordinator Pod will be started. The number of Coordinator nodes is fixed to 1.
Expand Down
4 changes: 2 additions & 2 deletions interactive_engine/compiler/set_properties.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

worker_num="pegasus.worker.num: $WORKER_NUM";

timeout="pegasus.timeout: $TIMEOUT"
query_timeout="query.execution.timeout.ms: $QUERY_TIMEOUT"

batch_size="pegasus.batch.size: $BATCH_SIZE";

Expand Down Expand Up @@ -47,6 +47,6 @@ done

graph_schema="graph.schema: $GRAPH_SCHEMA"

properties="$worker_num\n$timeout\n$batch_size\n$output_capacity\n$hosts\n$server_num\n$graph_schema\n$gremlin_server_port\n$cypher_server_port\n$frontend_query_per_second_limit\n$gremlin_script_language_name\n$graph_physical_opt"
properties="$worker_num\n$query_timeout\n$batch_size\n$output_capacity\n$hosts\n$server_num\n$graph_schema\n$gremlin_server_port\n$cypher_server_port\n$frontend_query_per_second_limit\n$gremlin_script_language_name\n$graph_physical_opt"

echo -e $properties > ./conf/ir.compiler.properties
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,4 @@ public class PegasusConfig {

public static final Config<String> PEGASUS_HOSTS =
Config.stringConfig("pegasus.hosts", "localhost:8080");

public static final Config<Long> PEGASUS_GRPC_TIMEOUT =
Config.longConfig("pegasus.grpc.timeout", 6000000L);
}
Loading