Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): refine maven log with --no-transfer-progress option #4174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Thespica
Copy link
Contributor

What do these changes do?

  • only run ci automatically when repository is alibaba/GraphScope
  • don't run ci if PR is draft or with WIP titile

Related issue number

close #4172

This PR is under assistance of Tongyi Lingma(本次 PR 借助通义灵码辅助完成)

image-20240821172534427

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Details:

Unknown scope "ci" found in pull request title "feat(ci): refine maven log with --no-transfer-progress option". Scope must match one of: core, python, k8s, coordinator, one, interactive, insight, analytical, learning, flex.

@Thespica Thespica changed the title feat(ci): refine CI trigger situation ci: refine CI trigger situation Aug 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.33%. Comparing base (4eadc2e) to head (9ac3fee).
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4174       +/-   ##
===========================================
- Coverage   46.45%   22.33%   -24.12%     
===========================================
  Files         173      203       +30     
  Lines       16171    18401     +2230     
===========================================
- Hits         7512     4110     -3402     
- Misses       8659    14291     +5632     

see 103 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b3f35...9ac3fee. Read the comment docs.

@acezen acezen changed the title ci: refine CI trigger situation feat(ci): refine CI trigger situation Aug 22, 2024
@acezen acezen requested a review from yecol August 22, 2024 02:48
@yecol
Copy link
Collaborator

yecol commented Aug 22, 2024

Hi @Thespica
Thanks for your commit!

However, I don't very agree with these modifications:

  • for alibaba/graphscope, the CI runs on forks is fine. It does not count to this repo quota;
  • for WIP, Github Draft function is turned on for this repo...

If for CI refinement, I suggest one thing is doable:
I also agree that --no-transfer-progress is much better than -q for maven build. :)

@Thespica
Copy link
Contributor Author

Hi @Thespica Thanks for your commit!

However, I don't very agree with these modifications:

  • for alibaba/graphscope, the CI runs on forks is fine. It does not count to this repo quota;
  • for WIP, Github Draft function is turned on for this repo...

If for CI refinement, I suggest one thing is doable: I also agree that --no-transfer-progress is much better than -q for maven build. :)

Thanks for your comment @yecol

So the target is that:

  1. Repo constraint: remain origin, partly run for forked repository;
  2. WIP PR: let WIP PR run CI;
  3. Maven log: replace -q by --no-transfer-progress to offer more info.

Right?

@yecol
Copy link
Collaborator

yecol commented Aug 22, 2024

Hi @Thespica, I mean:

  • Repo constraint: remain origin, partly run for forked repository; (Maybe no change needed;)
  • WIP PR: let WIP PR run CI; (Maybe no change needed;)
  • Maven log: replace -q by --no-transfer-progress to offer more info. (Yes!)

And other contributions or suggestions, (especially to improve user-friendliness and to get hands on) are warmly welcome!

@Thespica Thespica changed the title feat(ci): refine CI trigger situation ci: refine maven log with --no-transfer-progress option Aug 22, 2024
@Thespica Thespica changed the title ci: refine maven log with --no-transfer-progress option feat(ci): refine maven log with --no-transfer-progress option Aug 22, 2024
@Thespica
Copy link
Contributor Author

Hello @yecol

I consider the replacement of -q option has been done. But I am not sure about why CI failed. Please take a look and give me some suggestions, thank you!

@github-actions github-actions bot added the stale label Sep 12, 2024
Copy link
Contributor

/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: refine CI trigger situation
3 participants