Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support creating c++ stored procedure via gsctl #4222

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Sep 11, 2024

What do these changes do?

  • Support creating c++ stored procedure via gsctl
gsctl create storedproc -f procedure.yaml

# cat procedure.yaml
name: "cpp-procedure-name"
description: "This is a cpp test procedure"
query: "@/home/graphscope/sample_app.cc"
type: "cpp"
# cat sample_app.cc
namespace gs {
    class ExampleQuery : public CypherReadAppBase<int32_t> {}
}

Related issue number

Fixes #4216

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 34.33%. Comparing base (4eadc2e) to head (f8f0fb9).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
python/graphscope/gsctl/tests/test_interactive.py 0.00% 17 Missing ⚠️
python/graphscope/gsctl/commands/common.py 0.00% 4 Missing ⚠️
python/graphscope/gsctl/impl/stored_procedure.py 0.00% 4 Missing ⚠️
python/graphscope/gsctl/utils.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4222       +/-   ##
===========================================
- Coverage   46.45%   34.33%   -12.13%     
===========================================
  Files         173      126       -47     
  Lines       16171    13235     -2936     
===========================================
- Hits         7512     4544     -2968     
- Misses       8659     8691       +32     
Files with missing lines Coverage Δ
python/graphscope/gsctl/utils.py 0.00% <0.00%> (ø)
python/graphscope/gsctl/commands/common.py 0.00% <0.00%> (ø)
python/graphscope/gsctl/impl/stored_procedure.py 0.00% <0.00%> (ø)
python/graphscope/gsctl/tests/test_interactive.py 0.00% <0.00%> (ø)

... and 158 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5ebbd...f8f0fb9. Read the comment docs.

@lidongze0629 lidongze0629 changed the title Support creating c++ stored procedure via gsctl feat: Support creating c++ stored procedure via gsctl Sep 12, 2024
Copy link
Contributor

Please check the preview of the documentation changes at
https://d3e83436.graphscope-docs-preview.pages.dev

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbinlai longbinlai merged commit 1cc6569 into alibaba:main Sep 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating c++ procedure via gsctl
4 participants