-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] basic cluster concurrent flow control #1687
Open
yunfeiyanggzq
wants to merge
4
commits into
alibaba:master
Choose a base branch
from
yunfeiyanggzq:pr2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeiyanggzq
changed the title
basic cluster flow control
[feature] basic cluster concurrent flow control
Aug 21, 2020
Closed
yunfeiyanggzq
force-pushed
the
pr2
branch
2 times, most recently
from
August 22, 2020 00:49
8fe4fa6
to
690f140
Compare
sczyh30
added
area/cluster-flow
Issues or PRs related to cluster flow control
size/XXL
Indicate a PR that changes 1000+ lines.
to-review
To review
labels
Sep 1, 2020
Signed-off-by: yunfeiyanggzq <yunfeiyang@buaa.edu.cn>
Signed-off-by: yunfeiyanggzq <yunfeiyang@buaa.edu.cn>
…o sentinel core Signed-off-by: yunfeiyanggzq <yunfeiyang@buaa.edu.cn>
Signed-off-by: yunfeiyanggzq <yunfeiyang@buaa.edu.cn>
@sczyh30 @cdfive @jasonjoo2010 please cc |
@sczyh30 please cc if you have time ! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cluster-flow
Issues or PRs related to cluster flow control
size/XXL
Indicate a PR that changes 1000+ lines.
to-review
To review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
这个pr是 #1631 (已合并)的延续,应该在其后合并
本pr是 #1631 基础上完成的,已经实现了集群并发控制的基本功能,实现了控制并发数,应对客户端掉线、资源调用超时等情况,优先级请求block的阻塞策略请见下一个pr
四个commit分别完成以下功能:
完善client端,补充netty的encoder和decoder,完成DefaultTokenServerClient,注意释放token是异步通信,不管释放结果
完善server端,补充netty的processor、encoder、decoder,接入concurrentflowrulechecker,实现服务端流控规则管控
将集群并发控制接入sentinel core,将前两个pr的流控接入到flow slot。
完成demo
Does this pull request fix one issue?
Fixes #1697
Describe how you did it
Describe how to verify it
运行demo: https://github.com/yunfeiyanggzq/Sentinel/tree/pr2/sentinel-demo/sentinel-demo-cluster/sentinel-demo-cluster-concurrent ,分别运行server和client,可以体验分布式集群控制效果,可以通过print打印流控效果,也可以通过日志sentinel-server.log看流控记录,日志每秒打印并发控制信息并不是非常准确,但是能够大致反应流控情况。
nacos配置如下:
Special notes for reviews
本pr合并后我将完成集群并发控制的使用文档形成pr