Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Feature #1967 LoginAuthenticationFilter authFilterExcludeUrls match supports uri like /xx/** #1971

Merged
merged 2 commits into from
Jan 27, 2021
Merged

[feature] Feature #1967 LoginAuthenticationFilter authFilterExcludeUrls match supports uri like /xx/** #1971

merged 2 commits into from
Jan 27, 2021

Conversation

brotherlu-xcq
Copy link
Collaborator

Describe what this PR does / why we need it

LoginAuthenticationFilter authFilterExcludeUrls match supports uri like /xx/**

Does this pull request fix one issue?

Fixs #1967

Describe how you did it

add the org.springframework.util.AntPathMatcher to support matching the uri like /xx/**

Describe how to verify it

request the exclude urls

Special notes for reviews

@sczyh30 sczyh30 requested a review from cdfive January 19, 2021 02:33
@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Jan 19, 2021
@cdfive
Copy link
Collaborator

cdfive commented Jan 19, 2021 •
edited
Loading

Good method! How about we apply this new feature?
In application.properties: auth.filter.exclude-urls=/,/auth/login,/auth/logout,/registry/machine,/version
/auth/login,/auth/logout seems can reduced to /auth/* or /auth/**, both are ok.
the other url/auth/check can be accessed without login.

@brotherlu-xcq
Copy link
Collaborator Author

it seems can not work ideal with the current excludeUrls, we can keep this feature not change the properties auth.filter.exclude-urls. maybe this feature can be apply to the new excludeUrls in the future.

cdfive
cdfive approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing and provide this new feature!

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jan 27, 2021
@sczyh30 sczyh30 added this to the 1.8.1 milestone Jan 27, 2021
sczyh30
sczyh30 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit b7546c8 into alibaba:master Jan 27, 2021
@sczyh30
Copy link
Member

sczyh30 commented Jan 27, 2021

Thanks for contributing and look forward to more!

@sczyh30 sczyh30 linked an issue Jan 27, 2021 that may be closed by this pull request
建议LoginAuthenticationFilter 属性authFilterExcludeUrls配置支持uri: /xx/** #1967
Closed
@sczyh30 sczyh30 mentioned this pull request Jan 27, 2021
Closed
@brotherlu-xcq brotherlu-xcq deleted the feature-#1967 branch January 28, 2021 06:39
shenbaoyong pushed a commit to shenbaoyong/Sentinel that referenced this pull request Feb 5, 2021
@brotherlu-xcq @shenbaoyong
dashboard: authFilterExcludeUrls supports matching path pattern like …
e1540d1 
…/xx/** (alibaba#1971)
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
@brotherlu-xcq
dashboard: authFilterExcludeUrls supports matching path pattern like …
1d0d0a1 
…/xx/** (alibaba#1971)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 2, 2021
@brotherlu-xcq
dashboard: authFilterExcludeUrls supports matching path pattern like …
0217a71 
…/xx/** (alibaba#1971)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
@brotherlu-xcq
dashboard: authFilterExcludeUrls supports matching path pattern like …
97caefd 
…/xx/** (alibaba#1971)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
@brotherlu-xcq
dashboard: authFilterExcludeUrls supports matching path pattern like …
d9638ad 
…/xx/** (alibaba#1971)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 15, 2021
@brotherlu-xcq
dashboard: authFilterExcludeUrls supports matching path pattern like …
61def81 
…/xx/** (alibaba#1971)
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 15, 2021
@brotherlu-xcq
dashboard: authFilterExcludeUrls supports matching path pattern like …
ba39482 
…/xx/** (alibaba#1971)
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
@RongtongJin
Merge pull request alibaba#2039 from lebron374/comment_fix_v1
ecdeb1b 
[ISSUE alibaba#1971] Fix ConsumerFilterManager comment error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdfive cdfive cdfive approved these changes

@sczyh30 sczyh30 sczyh30 approved these changes

Assignees
No one assigned
Labels
area/dashboard Issues or PRs about Sentinel Dashboard kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.8.1
Development

Successfully merging this pull request may close these issues.

建议LoginAuthenticationFilter 属性authFilterExcludeUrls配置支持uri: /xx/**
3 participants
@brotherlu-xcq @cdfive @sczyh30