refactor(dashboard): use AuthConfiguration to manage bean of auth #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration for testing
sczyh30
added
area/dashboard
cdfive
reviewed
Mar 1, 2021
...nel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/config/AuthConfiguration.java
Show resolved
Hide resolved
Anilople
commented
Mar 1, 2021
...d/src/main/java/com/alibaba/csp/sentinel/dashboard/auth/DefaultAuthorizationInterceptor.java
Show resolved
Hide resolved
cdfive
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
LGTM
After refactoring, it's convenient for users to customize their own implementation of AuthService,LoginAuthenticationFilter,AuthorizationInterceptor, the dashboard module becomes more extensible. The idea of interface design and auto configuration is smart.
Thanks! @Anilople
|
Nice work. Thanks for contributing and look forward to more! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…ns (alibaba#2059) * refactor(dashboard): use AuthConfiguration to manage the bean of auth * refactor(dashboard): change AuthorizationInterceptor to an interface * refactor(dashboard): change LoginAuthenticationFilter to an interface * refactor(dashboard): use AuthProperties to manage auth config * test(dashboard): use NoAuthConfigurationTest to create no auth configuration for testing
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 4, 2021
…ns (alibaba#2059) * refactor(dashboard): use AuthConfiguration to manage the bean of auth * refactor(dashboard): change AuthorizationInterceptor to an interface * refactor(dashboard): change LoginAuthenticationFilter to an interface * refactor(dashboard): use AuthProperties to manage auth config * test(dashboard): use NoAuthConfigurationTest to create no auth configuration for testing
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 4, 2021
…ns (alibaba#2059) * refactor(dashboard): use AuthConfiguration to manage the bean of auth * refactor(dashboard): change AuthorizationInterceptor to an interface * refactor(dashboard): change LoginAuthenticationFilter to an interface * refactor(dashboard): use AuthProperties to manage auth config * test(dashboard): use NoAuthConfigurationTest to create no auth configuration for testing
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
…ns (alibaba#2059) * refactor(dashboard): use AuthConfiguration to manage the bean of auth * refactor(dashboard): change AuthorizationInterceptor to an interface * refactor(dashboard): change LoginAuthenticationFilter to an interface * refactor(dashboard): use AuthProperties to manage auth config * test(dashboard): use NoAuthConfigurationTest to create no auth configuration for testing
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
…ns (alibaba#2059) * refactor(dashboard): use AuthConfiguration to manage the bean of auth * refactor(dashboard): change AuthorizationInterceptor to an interface * refactor(dashboard): change LoginAuthenticationFilter to an interface * refactor(dashboard): use AuthProperties to manage auth config * test(dashboard): use NoAuthConfigurationTest to create no auth configuration for testing
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 16, 2021
…ns (alibaba#2059) * refactor(dashboard): use AuthConfiguration to manage the bean of auth * refactor(dashboard): change AuthorizationInterceptor to an interface * refactor(dashboard): change LoginAuthenticationFilter to an interface * refactor(dashboard): use AuthProperties to manage auth config * test(dashboard): use NoAuthConfigurationTest to create no auth configuration for testing
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
* fix DefaultLitePullConsumerImpl NPE * add ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
That will make auth module more flexible.
Does this pull request fix one issue?
#2053
Describe how you did it
Use
AuthConfigurationto manage bean under packagecom.alibaba.csp.sentinel.dashboard.auth.Change
AuthorizationInterceptorto an interface, and support a default implementation.Change
LoginAuthenticationFilterto an interface, and support a default implementation.Describe how to verify it
The beans are created successfully, and not break old testes.
Special notes for reviews