Apply volatile modifier to flowRules variable while keep concurrency … #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Moonergfp
approved these changes
Apr 13, 2021
|
Thanks for contributing! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…urrency semantics intact (alibaba#2107) - Revert alibaba#1783
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
…urrency semantics intact (alibaba#2107) - Revert alibaba#1783
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 16, 2021
…urrency semantics intact (alibaba#2107) - Revert alibaba#1783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…semantics intact (#2103)
Describe what this PR does / why we need it
Refactor
FlowRuleManageras suggested in issue #2103Does this pull request fix one issue?
Fixes #2103
Describe how you did it
Use
volatilekeyword instead ofAtomicReferenceforflowRulesvariable, the former is a lighter way to keep memory consistency.Describe how to verify it
Read the source code of
AtomicReference, It internally also usesvolatilekeyword,, so nothing is really changed.Special notes for reviews