Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACL token support for Consul data-source #2307

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

chenzhiguo
Copy link
Contributor

Describe what this PR does / why we need it

Add ACL token support for consul datasource

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zhiguo.Chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30 sczyh30 added the area/data-source Issues or PRs related to data-source extension label Jul 27, 2021
@sczyh30 sczyh30 changed the title Add ACL token support Add ACL token support for Consul data-source Jul 27, 2021
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 436a885 into alibaba:master Jul 27, 2021
@sczyh30
Copy link
Member

sczyh30 commented Jul 27, 2021

Thanks for contributing!

@sczyh30 sczyh30 added this to the 1.8.3 milestone Jul 27, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 16, 2021
Co-authored-by: Zhiguo.Chen <chenzhiguo@jd.com>
Zhang-0952 pushed a commit to Zhang-0952/Sentinel that referenced this pull request Mar 4, 2022
Co-authored-by: Zhiguo.Chen <chenzhiguo@jd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants