Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorityRuleManager并发场景下动态更新黑白名单,可能会导致黑白名单验证失效 #2655

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

zhuyou1234
Copy link
Contributor

修改黑白名单配置,先clear在去putAll。假设在此期间进行黑白名单验证,由于authorityRules已经被clear了,导致之前的黑白名单失效

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

修改黑白名单配置,先clear在去putAll。假设在此期间进行黑白名单验证,由于authorityRules已经被clear了,导致之前的黑白名单失效
@brotherlu-xcq brotherlu-xcq added the kind/enhancement Category issues or prs related to enhancement. label Apr 3, 2022
Copy link
Collaborator

@brotherlu-xcq brotherlu-xcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit b17ed64 into alibaba:master Apr 6, 2022
@sczyh30
Copy link
Member

sczyh30 commented Apr 6, 2022

Thanks for contributing!

sczyh30 pushed a commit that referenced this pull request Apr 6, 2022
@sczyh30 sczyh30 added this to the 1.8.4 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants