Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for dashboard with doc update #2970

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Conversation

wilsonwu
Copy link
Contributor

Describe what this PR does / why we need it

Add Dockerfile for sentinel-dashboard

Does this pull request fix one issue?

#2966

Describe how you did it

Just write a Dockerfile and tested:
image

image

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Nov 23, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 23, 2022

Hi, could you please move the Dockerfile and doc content to sentinel-dashboard directory? This is for dashboard rather than Sentinel itself :)

@sczyh30
Copy link
Member

sczyh30 commented Nov 25, 2022

cc @jnan806 for review

sentinel-dashboard/Dockerfile Outdated Show resolved Hide resolved
sentinel-dashboard/Dockerfile Outdated Show resolved Hide resolved
sentinel-dashboard/Dockerfile Outdated Show resolved Hide resolved
sentinel-dashboard/Dockerfile Outdated Show resolved Hide resolved
@wilsonwu wilsonwu requested a review from jnan806 November 25, 2022 05:10
sentinel-dashboard/Dockerfile Outdated Show resolved Hide resolved
@sczyh30
Copy link
Member

sczyh30 commented Nov 25, 2022

This Dockerfile works well with released version of the Sentinel dashboard. Actually we'll also need to build the dashboard image from scratch. We may make an improvement later :)

@sczyh30 sczyh30 merged commit cff298f into alibaba:master Nov 25, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 25, 2022

Thanks for contributing!

LearningGp pushed a commit that referenced this pull request Dec 28, 2023
* Add dockerfile for dashboard with doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants