-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for dashboard with doc update #2970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, could you please move the Dockerfile and doc content to |
cc @jnan806 for review |
jnan806
suggested changes
Nov 25, 2022
jnan806
suggested changes
Nov 25, 2022
jnan806
approved these changes
Nov 25, 2022
This Dockerfile works well with released version of the Sentinel dashboard. Actually we'll also need to build the dashboard image from scratch. We may make an improvement later :) |
sczyh30
approved these changes
Nov 25, 2022
Thanks for contributing! |
LearningGp
pushed a commit
that referenced
this pull request
Dec 28, 2023
* Add dockerfile for dashboard with doc update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Add Dockerfile for sentinel-dashboard
Does this pull request fix one issue?
#2966
Describe how you did it
Just write a Dockerfile and tested: