Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

实现 #3000 Issue的功能:Redis 数据源支持 SSL #3045

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

z521598
Copy link
Contributor

@z521598 z521598 commented Feb 19, 2023

Describe what this PR does / why we need it

实现 #3000 Issue的功能:Redis 数据源支持 SSL

Does this pull request fix one issue?

只有实现 #3000 Issue的功能:Redis 数据源支持 SSL

Describe how you did it

1)将lettuce版本从5.0.1升级至6.2.1,为了支持Redis SSL双向认证时的PEM格式的客户端证书与客户端私钥
2)在RedisConnectionConfig加入必要的参数,对接lettuce。
2.1)支持JSK格式,同时也支持PEM格式。
2.2)根据使用者的配置决定是采用 单向认证 还是 双向认证。

Describe how to verify it

Unit Test

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2023

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added to-review To review kind/feature Category issues or prs related to feature request. area/data-source Issues or PRs related to data-source extension labels Feb 20, 2023
@sczyh30
Copy link
Member

sczyh30 commented Feb 20, 2023

cc @BooAndBoCai @alibaba/sentinel-committer for review

@sczyh30
Copy link
Member

sczyh30 commented Feb 20, 2023

@z521598 Could you please resolve the test failure?
https://github.com/alibaba/Sentinel/actions/runs/4215604675/jobs/7324503594

@z521598
Copy link
Contributor Author

z521598 commented Feb 20, 2023

@z521598 Could you please resolve the test failure? https://github.com/alibaba/Sentinel/actions/runs/4215604675/jobs/7324503594

Of Course.

@z521598
Copy link
Contributor Author

z521598 commented Feb 20, 2023

@z521598 Could you please resolve the test failure? https://github.com/alibaba/Sentinel/actions/runs/4215604675/jobs/7324503594

Has been fixed.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 removed the to-review To review label Mar 15, 2023
@sczyh30 sczyh30 merged commit fd8966a into alibaba:master Apr 23, 2023
@sczyh30 sczyh30 added this to the v2.0.0 milestone Apr 23, 2023
@sczyh30
Copy link
Member

sczyh30 commented Apr 23, 2023

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I connect redis with ssl on sentinel-datasource-redis | Redis 数据源支持 SSL
3 participants