fix issues/1463 : Make default JUL-based logging asynchronous #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=3136 |
|
add asynchronous test cases |
sczyh30
requested changes
Jun 5, 2023
| @@ -42,6 +47,9 @@ class ConsoleHandler extends Handler { | |||
| * A Handler which publishes log records to System.err. | |||
| */ | |||
| private StreamHandler stderrHandler; | |||
| @SuppressWarnings("PMD.ThreadPoolCreationRule") | |||
There was a problem hiding this comment.
You have to follow the Java code guidelines rather than skip it with @SuppressWarnings. The queue should be bounded.
| @@ -34,6 +39,10 @@ public SimpleDateFormat initialValue() { | |||
| } | |||
| }; | |||
|
|
|||
| @SuppressWarnings("PMD.ThreadPoolCreationRule") | |||
| @@ -42,6 +47,9 @@ class ConsoleHandler extends Handler { | |||
| * A Handler which publishes log records to System.err. | |||
| */ | |||
| private StreamHandler stderrHandler; | |||
| @SuppressWarnings("PMD.ThreadPoolCreationRule") | |||
| private final ExecutorService executor = Executors.newSingleThreadExecutor( | |||
| new NamedThreadFactory("sentinel-log-executor", true)); | |||
There was a problem hiding this comment.
You may need to refine the thread name so that we could distinguish the actual type of the logging (e.g. to file or to console).
| @@ -79,6 +89,12 @@ public void flush() { | |||
|
|
|||
| @Override | |||
| public void close() throws SecurityException { | |||
| executor.shutdown(); | |||
| try { | |||
| executor.awaitTermination(3, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
Should we block and wait for termination here?
LearningGp
reviewed
Jun 6, 2023
sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/ConsoleHandler.java
Outdated
Show resolved
Hide resolved
LearningGp
reviewed
Jun 6, 2023
sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/DateFileLogHandler.java
Outdated
Show resolved
Hide resolved
added 7 commits
June 7, 2023 11:17
sczyh30
reviewed
Jun 26, 2023
|
Thanks for contributing! |
3 tasks
LearningGp
pushed a commit
that referenced
this pull request
Dec 28, 2023
* fix issues/1463 : Make default JUL-based logging asynchronous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Make default JUL-based logging asynchronous
Does this pull request fix one issue?
Fixes #1463
Describe how you did it
use java.util.concurrent.Executor, submit the log task into single thread.
Describe how to verify it
Special notes for reviews