make all ThreadPool static final #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robberphex
force-pushed
the
thread-pool
branch
3 times, most recently
from
a06cf9e
to
39608c1
Compare
robberphex
force-pushed
the
thread-pool
branch
from
80f3da4
to
8a5a8a0
Compare
LearningGp
pushed a commit
that referenced
this pull request
Dec 28, 2023
* make all ThreadPool static final * update github workflow
z-soulx
pushed a commit
to z-soulx/Sentinel
that referenced
this pull request
May 27, 2024
* make all ThreadPool static final * update github workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
There are some thread pools associated with class instance, which might cause many thread pools created.
Does this pull request fix one issue?
NONE
Describe how you did it
make all thread poll is static final, do not create thread pool dynamically.
Describe how to verify it
Start an application with sentinel, we could notice that all threads associated with an static field.
Special notes for reviews