Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jdk17 #3339

Merged
merged 17 commits into from
Feb 20, 2024
Merged

Support jdk17 #3339

merged 17 commits into from
Feb 20, 2024

Conversation

robberphex
Copy link
Collaborator

@robberphex robberphex commented Feb 20, 2024

Describe what this PR does / why we need it

Support JDK17:

  1. Adjust the test logic, use jdk17 to build, 8, 11, 17 to run
  2. Spring boot test version was upgraded to 2.4 in order to run under jdk17
  3. 'sentinel-annotation-cdi-interceptor' module, because the related dependency does not support jdk17, so ignore the test case for the time being
Chinese/中文

支持JDK17:

  1. 调整测试逻辑,使用jdk17构建,8、11、17运行
  2. Spring boot 测试版本升级到2.4,为了能够在jdk17下运行
  3. sentinel-annotation-cdi-interceptor模块,因为相关依赖没有支持jdk17,所以暂时忽略测试用例

Does this pull request fix one issue?

#2797

Describe how you did it

Describe how to verify it

Special notes for reviews

@robberphex robberphex changed the title Jdk17 Support jdk17 Feb 20, 2024
Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp added the area/test Issue or PR related to test cases label Feb 20, 2024
Copy link
Collaborator

@panxiaojun233 panxiaojun233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit 8fef1b5 into alibaba:1.8 Feb 20, 2024
7 checks passed
@robberphex robberphex deleted the jdk17 branch February 20, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Issue or PR related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants