Modify variable names and Optimize methods

[yidadi]

Modify variable names and Optimize methods

[CLAassistant]

All committers have signed the CLA.

[codecov-io]

Codecov Report

Merging #871 into master will increase coverage by 0.03%.
The diff coverage is 54.54%.

@@             Coverage Diff              @@
##             master     #871      +/-   ##
============================================
+ Coverage     42.16%   42.19%   +0.03%     
- Complexity     1416     1418       +2     
============================================
  Files           307      307              
  Lines          8897     8894       -3     
  Branches       1204     1203       -1     
============================================
+ Hits           3751     3753       +2     
+ Misses         4685     4682       -3     
+ Partials        461      459       -2

Impacted Files	Coverage Δ	Complexity Δ
...baba/csp/sentinel/slotchain/SlotChainProvider.java	63.15% <54.54%> (-0.48%)	5 <3> (ø)
...inel/datasource/zookeeper/ZookeeperDataSource.java	67.32% <0%> (+0.99%)	16% <0%> (+1%)	⬆️
...a/csp/sentinel/slots/statistic/base/LeapArray.java	70.29% <0%> (+2.97%)	34% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba14676...f269376. Read the comment docs.

[sczyh30]

Hi, could you please illustrate why these changes are necessary?

[yidadi]

This method #resolveSlotChainBuilder just get the first SlotChainBuilder from the list.

[sczyh30]

Maybe your change is not compatible with the current design:

• If there is no user-defined SlotChainBuilder, then use the default slot chain builder
• If user-defined SlotChainBuilder exists, the provider will pick the first loaded customized slot chain builder, then cache the builder.

See #145 for details.

[yidadi]

Why? Is it necessary to put an object in a list and get only the first one?

[sczyh30]

The list was initially designed for different strategies (e.g. pick the first customized, pick the final customized or ordered by @SpiOrder) but is not actually used indeed... I think it's okay to remove the list, but support for @SpiOrder should also be considered (we could leverage the SpiLoader class). For further improvement of the slot SPI, we could refer to #316

[sczyh30]

LGTM

[sczyh30]

Thanks!