Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JUnit 5 #2661

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Upgrade to JUnit 5 #2661

merged 2 commits into from
Sep 20, 2023

Conversation

yanyir
Copy link
Contributor

@yanyir yanyir commented Sep 15, 2023

#2517 #2530

  • Modify pom.xml in arthas-all:
    • In dependency management section, change the part of junit:junit:4.13.2 to import org.junit:junit-bom to manage JUnit version, version 5.10.0
  • Modify the pom.xml of the modules that utilize JUnit for testing:
  • Use dependency org.junit.vintage:junit-jupiter-engineto enable the execution of vintage tests (based on JUnit 3.8 and JUnit 4) using the JUnit Platform launcher infrastructure
  • Add the dependency org.junit.jupiter:junit-jupiter of JUnit 5
  • Remove a redundant JUnit dependency from module arthas-testcase

@hengyunabc hengyunabc added this to the 4.0.0 milestone Sep 20, 2023
@hengyunabc hengyunabc merged commit e7baa38 into alibaba:master Sep 20, 2023
12 checks passed
@hengyunabc hengyunabc mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants