Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump RSTA from 2.5.8 to 3.3.4 #2677

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Bump RSTA from 2.5.8 to 3.3.4 #2677

merged 2 commits into from
Sep 25, 2023

Conversation

yanyir
Copy link
Contributor

@yanyir yanyir commented Sep 22, 2023 •
edited
Loading

#2530

  • Set rsyntaxtextarea version to 3.3.4 in pom.xml

@hengyunabc
Copy link
Collaborator

这个要检查

  1. 打包之后的 arthas zip 包大小变化。
  2. jad 命令的语法高亮是否正常工作，对高版本的 jdk 是否有支持新的语法

@yanyir
Copy link
Contributor Author

yanyir commented Sep 24, 2023

这个要检查

  1. 打包之后的 arthas zip 包大小变化。
  2. jad 命令的语法高亮是否正常工作，对高版本的 jdk 是否有支持新的语法

  1. 打包之后 arthas zip 包确实变大了一些，大致从 19.1MB 变成 19.3 MB 这样；

  2. 暂未发现 jad 命令的语法高亮有运行异常。对高版本的 jdk 有部分新的语法高亮支持，比如新的关键字，例如 record：
    旧版本不会高亮↓
    image
    新版本有高亮↓
    image

@hengyunabc hengyunabc added this to the 4.0.0 milestone Sep 25, 2023
@hengyunabc hengyunabc merged commit a6a9dcd into alibaba:master Sep 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yanyir @hengyunabc