Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复rocketmq&kafka 发送消息失败时回滚后继续提交的问题 #1104

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

jiacheo
Copy link
Contributor

@jiacheo jiacheo commented Nov 5, 2018

现象

发送message到rocket或者kafka的时候,如果发送失败会在异常处回滚,但回滚后依然提交,会报错:

ERROR com.alibaba.otter.canal.server.CanalMQStarter - ack error , clientId:1001 batchId:16 is not exist , please check

虽然,从整体上看,不影响rollback的效果,但是异常却变成了在ack处,排查问题容易引起误会。

改进思路

rollback之后,立即结束处理即可。

…:1001 batchId:12 is not exist , please check 的错误。
@agapple agapple merged commit 238da87 into alibaba:master Nov 5, 2018
@agapple
Copy link
Member

agapple commented Nov 5, 2018

tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants