Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

加个兼容来规避JavaBeanBinder获取属性信息的问题 #5785 #5796

Merged
merged 6 commits into from
Mar 24, 2024

Conversation

lizongbo
Copy link
Collaborator

druid starter实现不太好,但是不好大改,先加个兼容来规避JavaBeanBinder获取属性信息的问题 #5785

druid starter实现不太好,但是不好大改,先加个兼容来规避JavaBeanBinder获取属性信息的问题 alibaba#5785
补充个warn日志方便后续分析问题
优化注释解析与输出 alibaba#5791  不小心跟前面混在一起提交了,因此合并成一个pr来操作
调整测试用例,支持注释
去除多余的空行
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.78431% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 58.67%. Comparing base (fa195c0) to head (a29d95c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5796   +/-   ##
=========================================
  Coverage     58.66%   58.67%           
- Complexity    27898    27911   +13     
=========================================
  Files          1341     1341           
  Lines        128217   128268   +51     
  Branches      24186    24202   +16     
=========================================
+ Hits          75223    75259   +36     
- Misses        43616    43627   +11     
- Partials       9378     9382    +4     
Files Coverage Δ
...a/druid/sql/ast/statement/SQLSelectQueryBlock.java 39.80% <100.00%> (+0.21%) ⬆️
...id/sql/dialect/mysql/parser/MySqlSelectParser.java 74.90% <100.00%> (+0.09%) ⬆️
.../sql/dialect/mysql/visitor/MySqlOutputVisitor.java 60.44% <100.00%> (+0.03%) ⬆️
...id/sql/dialect/odps/visitor/OdpsOutputVisitor.java 54.25% <100.00%> (+0.43%) ⬆️
.../com/alibaba/druid/sql/parser/SQLSelectParser.java 59.19% <100.00%> (+0.06%) ⬆️
...n/java/com/alibaba/druid/pool/DruidDataSource.java 70.55% <66.66%> (-0.06%) ⬇️
.../sql/dialect/oracle/parser/OracleSelectParser.java 74.73% <50.00%> (-0.08%) ⬇️
...ql/dialect/oracle/visitor/OracleOutputVisitor.java 71.26% <66.66%> (-0.03%) ⬇️
.../sql/dialect/oscar/visitor/OscarOutputVisitor.java 0.00% <0.00%> (ø)
...lect/sqlserver/visitor/SQLServerOutputVisitor.java 68.55% <0.00%> (-0.66%) ⬇️
... and 2 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa195c0...a29d95c. Read the comment docs.

@lizongbo lizongbo merged commit 1a9f216 into alibaba:master Mar 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants