-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bazel): add MODULE.bazel files for bzlmod #30
Conversation
f7da0fd
to
8d390f0
Compare
55c4ed7
to
577018a
Compare
4d11c6b
to
c7d4fa2
Compare
Thank you very much for your contribution, but it seems that ci did not pass. I will check the reason why ci failed, but it may take a while. cc @zyfjeff |
MODULE.bazel
Outdated
repo_name = "com_google_googletest", | ||
) | ||
bazel_dep( | ||
name = "bazel-compile-commands-extractor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the name of bazel_dep does not match the definition in the dependent Module, Bazel will throw an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the repo_name is here for that
I test it on my computer, and it appears that the reason for the build demo failure is due to
After I removed the |
Let's keep this a draft until this bazelbuild/bazel-central-registry#1989 is merged |
Thank you very much. |
@Lynskylate , that’s ready for your review. There won’t be any change concerning hedron_compile_commands |
git-override implict do same action as dev_dependency.
This is also the reason why it fails to load I am still reading the documentation on dev dependencies to see if I should consider loading that target only when in dev dependency mode. |
I created this : bazelbuild/bazel-central-registry#2054 I believe adding to the BCR is going to become a necessity. |
I may not have been clear. So if we want to fix the error, Perhaps we could first simply remove the refresh_compile from the hessian2-codec BUILD. |
And i have test the different version bazel for the build, it can build in bazel 6.0 but can't work in bazel 7.0+. |
It can be removed if you don't need it but if bazelbuild/bazel-central-registry#2055 get merged we shall be able to make things works. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@Lynskylate, can you retry? |
I apologize for not responding promptly. I have tested before, and there might be some issues with calculating coverage after migrating to the module. We can merge this PR first, and then I will create another PR to fix this issue. |
@zyfjeff @wbpcode The current compilation parameters under the demo will cause a failure, and in addition to this, there is also an incompatibility with coverage. You could see the action detail. |
@mmorel-35 Thanks for your contribution. |
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com