Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1053

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fix typos #1053

merged 3 commits into from
Jun 26, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jun 23, 2024

Ⅰ. Describe what this PR did

Fix typos

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.89%. Comparing base (6e4ade0) to head (916da3e).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   35.97%   35.89%   -0.08%     
==========================================
  Files          69       69              
  Lines       11514    11549      +35     
==========================================
+ Hits         4142     4146       +4     
- Misses       7056     7087      +31     
  Partials      316      316              
Files Coverage Δ
pkg/ingress/config/ingress_config.go 13.87% <0.00%> (+0.49%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@johnlanni johnlanni merged commit 9c6ea10 into alibaba:main Jun 26, 2024
8 checks passed
@co63oc co63oc deleted the fix1 branch June 27, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants