Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Load 3rd-party images from higress image repo #1067

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jun 28, 2024

Ⅰ. Describe what this PR did

Load 3rd-party images from higress image repo.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni
Copy link
Collaborator

johnlanni commented Jul 2, 2024

This should require support for multiple architectures. Shall we solve this throught docker manifest?

@CH3CHO
Copy link
Collaborator Author

CH3CHO commented Jul 3, 2024

This should require support for multiple architectures. Shall we solve this throught docker manifest?

I'll see if we can do it.

@CH3CHO
Copy link
Collaborator Author

CH3CHO commented Jul 4, 2024

This should require support for multiple architectures. Shall we solve this throught docker manifest?

I'll see if we can do it.

I've synced all image arcitectures found in Docker Hub to the Higress image repo.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnlanni johnlanni merged commit 4bbfb13 into alibaba:main Jul 4, 2024
8 checks passed
@CH3CHO CH3CHO deleted the feat/image-repo branch July 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants