-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add build-and-push-wasm-plugin-image.yaml #1069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
整体看上去没什么问题。明后天我会测一下各个场景。
fi | ||
|
||
# 查找README.md | ||
case "$(ls ${workspace}/README*.md 2>/dev/null)" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么这里没有选择继续使用 -f
判定呢?
file_name=$(basename $file) | ||
echo "$file_name exists" | ||
lang=$(basename $file | sed 's/README_//; s/.md//') | ||
push_command="$push_command ./$file_name:application/vnd.module.wasm.doc.v1.$lang+markdown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 $lang
可以考虑转一下小写
@CH3CHO 我做出了修改,麻烦review。
验证 环境介绍
经 途径一:通过配置清单部署打包好的 途径二:通过控制台新增插件,同样可以拒绝访问。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
功能:添加了利用 GitHub Actions 来自动完成相应的镜像构建和发布工作的Workflow。支持通过push tag和手动触发两种方式。同时也遵循使用oras打包工具。
特点:完全按照Wasm 插件镜像规范进行镜像打包。
更新:
spec.yaml
、README.md
和README-{lang}.md
三个文件,有则在打包推送镜像时设置相应的media type
。builder
容器的启动命令为docker run -itd --name builder xxx /bin/bash
,之前使用sleep 99999
是希望容器保持后台持续运行,这样只适合测试容器,不适合在生产环境中使用。PR
是因为错误地提交了一些没用的commit
,不太会删除,担心破坏仓库并且为了保持PR
整洁所以重新提交。Ⅱ. Does this pull request fix one issue?
fixes #1052
Ⅳ. Describe how to verify it
1.准备工作



添加Repository Secrets和 Repository variables。
2.通过
push tag
触发,先查找相关文件,然后将特定的插件打包成镜像并推送至指定仓库。3.人工触发,指定插件名和版本号
Ⅴ. Special notes for reviews
这是我第一次参与开源贡献,希望能有所帮助!
本次贡献借助了通义灵码以及通义千问。



