-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add full push when higress-https configmap updated and fix certmagic storage #1105
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
- Coverage 35.89% 35.84% -0.06%
==========================================
Files 69 69
Lines 11549 11587 +38
==========================================
+ Hits 4146 4153 +7
- Misses 7087 7118 +31
Partials 316 316
|
bb886e7
to
04a6ef4
Compare
@johnlanni 麻烦看一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要代码注释说明一下certmagic的证书存储原理,按目前代码理解,证书在configmap和secret里似乎冗余存储了?
38699e7
to
2d533fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
阿里云 新加波 搭了 higress cluster
higress-cert-store-certificates-92abe106 yaml 如下:
renew 日志如下:
foo-com-secretsecret yaml info 如下:
这里看到 secret已经Renew
![截屏2024-07-11 12 30 20](https://private-user-images.githubusercontent.com/108045855/347684985-49ce4ff7-b1eb-4ae7-9925-15200a3d3101.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1ODA0MzUsIm5iZiI6MTcyNDU4MDEzNSwicGF0aCI6Ii8xMDgwNDU4NTUvMzQ3Njg0OTg1LTQ5Y2U0ZmY3LWIxZWItNGFlNy05OTI1LTE1MjAwYTNkMzEwMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyNVQxMDAyMTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04ZmY1MmViYjQ1YjUzMTAwN2FhYjRhZmZiOTc0ZTg5OGY5MTViYjZiM2NmOTI4ODk5NjhkNGVkOGQ2NmM5N2NmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.V5An5CeJ243LCvrSyJIhJtv_2JxsXl8hUm4JXeYxtaM)
https://8.222.156.101.sslip.io/
证书签发日期变更成最新日期。
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews